Use first qor-field for select2-result-template and select2-selection…#65
Open
glebtv wants to merge 1 commit intoqor:masterfrom
Open
Use first qor-field for select2-result-template and select2-selection…#65glebtv wants to merge 1 commit intoqor:masterfrom
glebtv wants to merge 1 commit intoqor:masterfrom
Conversation
…-template This is needed for serializeable_meta because it wraps multiple fields with qor-field
jasonweng
reviewed
Apr 19, 2017
Member
jasonweng
left a comment
jasonweng
left a comment
There was a problem hiding this comment.
You don't have to add .first() selector, $this.parents('.qor-field') will find the closest .qor-field tag.
Please take a screenshot for your HTML structrue. i don't think .first() selector is necessary.
Author
|
This in in "worker/jobs" page, arguments to a job. .parents() finds not the first but all matching parents up to |
Member
|
Use .closest('. qor-field') is works for you? |
|
@glebtv: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed for serializeable_meta because it wraps multiple fields with qor-field, so all fields will have the first one's template.